From: Stefan Sperling <stsp@stsp.name>
Subject: Re: make 'got add' robert-compatible
To: Raf Czlonka <rczlonka@gmail.com>
Cc: "Todd C. Miller" <Todd.Miller@sudo.ws>, gameoftrees@openbsd.org
Date: Thu, 8 Jul 2021 13:01:40 +0200

On Thu, Jul 08, 2021 at 11:53:49AM +0100, Raf Czlonka wrote:
> On Thu, Jul 08, 2021 at 11:28:44AM BST, Stefan Sperling wrote:
> > One option is to list ignored files as such, using a new status code.
> > I've already played with this. An earlier version of my patch printed this:
> > 
> >  $ got add foo.core
> >  I foo.core
> >  $
> 
> Perhaps I didn't make myself clear - by "a warning or an error
> message", I meant the above, i.e. the "status code" :^)

I see. Sorry, I misunderstood. To me, an error implies that the program
stops before the operation has completed and then produces an error message.

> > This tells the user why foo.core wasn't added, which on the surface
> > seems much better than the behaviour implemented by my current patch,
> > which looks like this:
> > 
> >  $ got add foo.core
> >  $
> 
> And "at some point" as opposed to "never" would be good since, if
> there was an internal hard-coded ignore list, it would avoid some
> serious head scratching should the below failed silently:
> 
> 	$ got add foo.core
> 
> I think we're on the same page :^)

Yes, with the addition of a default ignore list the behaviour of
silently ignoring such files could indeed be rather confusing.