From: Stefan Sperling <stsp@stsp.name>
Subject: Re: tog: handle Home/End for log and diff views
To: Jasper Lievisse Adriaanse <j@jasper.la>
Cc: gameoftrees@openbsd.org
Date: Mon, 30 Aug 2021 20:50:41 +0200

On Mon, Aug 30, 2021 at 08:07:53PM +0200, Jasper Lievisse Adriaanse wrote:
> > +		if (!s->thread_args.log_complete) {
> > +			s->thread_args.load_all = 1;
> > +			return trigger_log_thread(view, 0);
> >  		}
> > -
> > +	
> Looks like an extra tab snuck in here.

Thanks, fixed.

> The manpage could use a small tweak along these lines:

I think it is good to mention Backspace where the End/G keys are
explained. Otherwise, people might miss it. Such as:

diff fb280deb15e67b1bd8ef0f722a7430b8e9312871 /home/stsp/src/got
blob - 3d45c560c4bb01de1b6dee76d385939f0928c426
file + tog/tog.1
--- tog/tog.1
+++ tog/tog.1
@@ -114,6 +114,8 @@ Move the cursor to the newest commit.
 Move the cursor to the oldest commit.
 This will iterate over all commit objects in the repository and may take
 a long time depending on the size of the repository.
+If needed this operation can be cancelled with
+.Cm Backspace .
 .It Cm Enter, Space
 Open a
 .Cm diff
 
We could apply both diffs?

> --- a/tog/tog.1
> +++ b/tog/tog.1
> @@ -123,10 +123,11 @@ Open a
>  .Cm tree
>  view showing the tree for the currently selected commit.
>  .It Cm Backspace
> -Show log entries for the parent directory of the currently selected path,
> -unless an active search is in progress in which case
> +Show log entries for the parent directory of the currently selected path.
> +However when an active search is in progress or when additional commits
> +are loaded,
>  .Cm Backspace
> -aborts the search.
> +aborts the running operation.
>  .It Cm /
>  Prompt for a search pattern and start searching for matching commits.
>  The search pattern is an extended regular expression which is matched
> 
> 
> -- 
> jasper
> 
>