From: Stefan Sperling <stsp@stsp.name>
Subject: Re: Pointer sign warnings
To: Christian Weisgerber <naddy@mips.inka.de>
Cc: gameoftrees@openbsd.org
Date: Tue, 28 Sep 2021 20:31:28 +0200

On Tue, Sep 28, 2021 at 08:15:07PM +0200, Christian Weisgerber wrote:
> Christian Weisgerber:
> 
> > There are, however, a bunch of low-hanging fruits:
> 
> And finally:
> (3) got_sha1_digest_to_str writes to char *

ok

>  
> diff 430f73133f7f6c6c095bfcb6ec3aac1435ba1062 272cc6d4ba51a67380950743707be8089733001b
> blob - fde331d19fb3c439f182eec39b182eb68efe2b4e
> blob + debec1726d7defbd2dd5322b460ae1d739329fb3
> --- lib/reference.c
> +++ lib/reference.c
> @@ -1334,7 +1334,7 @@ delete_packed_ref(struct got_reference *delref, struct
>  		}
>  
>  		TAILQ_FOREACH(re, &refs, entry) {
> -			uint8_t hex[SHA1_DIGEST_STRING_LENGTH];
> +			char hex[SHA1_DIGEST_STRING_LENGTH];
>  
>  			if (got_sha1_digest_to_str(re->ref->ref.ref.sha1, hex,
>  			    sizeof(hex)) == NULL) {
> 
> 
> -- 
> Christian "naddy" Weisgerber                          naddy@mips.inka.de
> 
>