From: Stefan Sperling <stsp@stsp.name>
Subject: Re: fix got_opentemp() overhead of got-read-pack
To: gameoftrees@openbsd.org
Date: Tue, 4 Jan 2022 21:18:42 +0100

On Mon, Jan 03, 2022 at 03:00:14PM +0100, Stefan Sperling wrote:
> On Fri, Dec 31, 2021 at 07:02:31PM +0100, Stefan Sperling wrote:
> > Turns out the problem where gotadmin pack spends about 30% of its time
> > opening temporary files can be fixed independently from using mmap.
> > 
> > With this patch we open temporary files used during delta application
> > just once, instead of opening new temporary files during every request
> > for a blob object or a raw object.
> > 
> > This makes gotadmin pack significantly faster, and will likely also
> > speed up other tasks which need to load a lot of blobs.
> > 
> > ok?
> 
> The previous patch triggered pledge violations for commands which
> do not use the "cpath" promise, such as 'got branch -l'.
> 
> This is fixed in the new version below. We can wait with opening
> temporary files until we are certain that they will be needed, i.e.
> when a request for a blob or a raw object is sent to the child.
> 
> ok?

I have committed this earlier today.