From: Stefan Sperling <stsp@stsp.name>
Subject: Re: Workflow question, maybe bug or unclear usage.
To: "Todd C. Miller" <millert@openbsd.org>
Cc: Christian Weisgerber <naddy@mips.inka.de>, gameoftrees@openbsd.org
Date: Thu, 27 Jan 2022 16:29:03 +0100

On Thu, Jan 27, 2022 at 08:04:43AM -0700, Todd C. Miller wrote:
> On Thu, 27 Jan 2022 15:56:52 +0100, Christian Weisgerber wrote:
> 
> > I feel a bit uncomfortable about assigning to dirent->d_type,
> > although I can't find a reason against it.  Nothing in OpenBSD base
> > does it, though.  Hmm.
> 
> d_type is a non-standard extension but I don't know that we really
> care about portability to anything other than BSD and Linux.

The value we are overwriting is "UNKNOWN", which cannot be acted upon.
And we are likely filling in correct information. So I do not see a real
downside to overwriting d_type.

However, we can of course pass a separate variable around if this is
a concern.