From: Stefan Sperling Subject: Re: Workflow question, maybe bug or unclear usage. To: "Todd C. Miller" Cc: Christian Weisgerber , gameoftrees@openbsd.org Date: Thu, 27 Jan 2022 22:00:32 +0100 On Thu, Jan 27, 2022 at 08:32:27AM -0700, Todd C. Miller wrote: > On Thu, 27 Jan 2022 16:29:03 +0100, Stefan Sperling wrote: > > > The value we are overwriting is "UNKNOWN", which cannot be acted upon. > > And we are likely filling in correct information. So I do not see a real > > downside to overwriting d_type. > > I think writing to d_type is fine. I was just pointing out the > portability issues with using d_type without wrapping it in some > way. I wasn't aware of that, but d_type has been used by this code since forever. naddy, would you still prefer a separate variable? I don't mind.