From: Stefan Sperling <stsp@stsp.name>
Subject: Re: got patch: reverse patches
To: Omar Polo <op@omarpolo.com>
Cc: gameoftrees@openbsd.org
Date: Sat, 23 Apr 2022 10:57:04 +0200

On Sat, Apr 23, 2022 at 10:22:21AM +0200, Omar Polo wrote:
> got-read-patch currently ignores the "\ No newline at end of file"
> marker after a "-" line: this is to simplify the matching routines and
> because to apply a diff we're really interested only in the marker if it
> follows a "+" line.
> 
> This, however, gets in the way of reversing patches because then a "\"
> marker after a "-" line suddely becomes interesting...
> 
> I intend to commit the following in two steps if it looks good: first
> the refactoring where got-read-patch sends all the "\" lines, and a
> second commit for the reversing itself.
> 
> (I've sent this diff previously, now it's rebased on top of recent
> changes and not split into two)

I don't see any problems here. ok stsp@