From: Omar Polo <op@omarpolo.com>
Subject: Re: search deltas to reuse in got-read-pack
To: Stefan Sperling <stsp@stsp.name>
Cc: gameoftrees@openbsd.org
Date: Sat, 07 May 2022 12:27:37 +0200

Stefan Sperling <stsp@stsp.name> wrote:
> Run the search for deltas to reuse directly in got-read-pack.
> 
> This significantly speeds up the 'deltify' step of packing by
> avoiding imsg traffic. gotadmin no longer requests individual raw
> deltas from got-read-pack to check whether it can reuse them.
> Instead, got-read-pack obtains a list of objects we want to pack,
> and hands back the list of all deltas in its pack file which can be
> reused. Messages are now batched such that imsg buffers are filled
> as much as possible.
> 
> Another advantage is that deltas we are not going to reuse will
> no longer be written to the delta cache file, saving disk space.
> Before this patch, any raw delta candidate was written to the
> delta cache file by got-read-pack, and the decision whether to
> reuse the delta happened afterwards in the gotadmin process.
> 
> This patch requires all the other outstanding patches I have sent
> to the list which aren't committed yet.
> 
> Code for reading individual raw deltas is now unused and could be
> removed. I have left it in place for now to keep this diff shorter.
> 
> ok?

ok op

`gotadmin pack -a' on src.git takes 4 minute less!