From: Tracey Emery <tracey@traceyemery.net>
Subject: Re: Move got_opentempfd out of got_repo_open
To: gameoftrees@openbsd.org
Date: Thu, 2 Jun 2022 12:35:29 -0600

On Thu, Jun 02, 2022 at 08:03:59PM +0200, Stefan Sperling wrote:
> On Thu, Jun 02, 2022 at 10:47:26AM -0600, Tracey Emery wrote:
> > Here we go with those changes.
>  
> What is the reason for moving GOT_PACK_CACHE_SIZE to the public
> header? Does gotweb need it for some reason? If not, could we keep
> it in got_lib_repository.h?
> 
> Could GOT_PACK_NUM_TEMPFILES be declared at the top of lib/repository.c
> or does any code outside this file need to know its value?
> 

No, I don't think there is a reason. I've just had this stuck in my head
since this morning! LOL

"Instead, we could declare GOT_PACK_CACHE_SIZE in a public header,
and perhaps declare GOT_PACK_CACHE_SIZE * 2 as another macro"

Before I send a nearly final diff, any objections to moving the closing
of the fds out to a got_repo_pack_fds_close()? It seems odd to me to
open the fds by the caller, but a hidden process closing them for the
caller. For example, got_repo_close isn't magic. Thoughts about that?

-- 

Tracey Emery