From: Stefan Sperling Subject: Re: [patch] filter log by author pattern To: Mikhail Cc: Evan Silberman , gameoftrees@openbsd.org Date: Sat, 11 Jun 2022 21:20:43 +0200 On Sat, Jun 11, 2022 at 07:01:37PM +0300, Mikhail wrote: > On Sat, Jun 11, 2022 at 06:57:36PM +0300, Mikhail wrote: > > On Sat, Jun 11, 2022 at 09:16:45AM +0200, Stefan Sperling wrote: > > > On Fri, Jun 10, 2022 at 11:00:16PM -0700, Evan Silberman wrote: > > > > Hey, I had another idea that I could implement mostly by copy-pasting. > > > > Or pattern-matching if you will. Patch adds got log -a author-pattern to > > > > filter commits by author. By analogy with git log --author, hg log > > > > --user, rlog -w. (Feature is missing from fossil timeline, svn log.) > > > > > > > > Caveats vs. git: no matching -c for committer, no support for multiple > > > > instances of the option. > > > > > > Any reason why author/committer couldn't be matched by -S as well, > > > instead of adding a new option? > > > > Commit messages usually contains text like 'ok stsp@', which will be > > matched in case of -S, and it's probably is not what desired. > > > > The patch applies and works well. > > Well, just got what you probably meant - one is supposed to write full > author info, like 'stsp@openbsd.org' to get proper result, so probably > -S matching author/committer is a right way. Yes. If a regex matches things you don't want to see, then the regex can be improved to match only the things you want to see.