From: Mark Jamsek Subject: Re: tog: horizontal split To: Omar Polo Cc: gameoftrees@openbsd.org Date: Wed, 29 Jun 2022 00:01:01 +1000 On 22-06-28 03:48pm, Omar Polo wrote: > Mark Jamsek wrote: > > The patch seems to break scrolling in hsplit. Could you please confirm > > if you can reproduce the same behaviour (i.e., this patch on top of the > > diff in the OP scrolls offscreen in hsplit?) > > yup, it's happening here too :/ > > my guess is that we're forgetting to resize the master view when > hsplitting (or using a wrong value), because it starts scrolling after a > while... I'm going to investigate a little before calling it a night to see if I can find where. I haven't spent this long on a bug in a while! > only slightly related, but I was thinking of trying to drop the panel > library in tog now that we're properly resizing the windows for the > splits. (before it was needed because the child window was rendered _on > top_ of the main one, that's not the case anymore.) That's ok with me. Considering we only go one child deep, there shouldn't be too much surgery. I don't know if you want to do this now or leave it till after we get hsplits sorted? -- Mark Jamsek GPG: F2FF 13DE 6A06 C471 CA80 E6E2 2930 DC66 86EE CF68