From: Omar Polo Subject: Re: tog: horizontal split To: Mark Jamsek Cc: gameoftrees@openbsd.org Date: Tue, 28 Jun 2022 16:38:51 +0200 Mark Jamsek wrote: > On 22-06-28 03:48pm, Omar Polo wrote: > > Mark Jamsek wrote: > > > The patch seems to break scrolling in hsplit. Could you please confirm > > > if you can reproduce the same behaviour (i.e., this patch on top of the > > > diff in the OP scrolls offscreen in hsplit?) > > > > yup, it's happening here too :/ > > > > my guess is that we're forgetting to resize the master view when > > hsplitting (or using a wrong value), because it starts scrolling after a > > while... > > I'm going to investigate a little before calling it a night to see if > I can find where. I haven't spent this long on a bug in a while! eheh to add another issue (sorry!) I can get some glitches (and even errors!) from slowly making the window taller and then smaller than it was initially. some sizes goes out-of-sync, and tog eventually quits with tog: wresize: Interrupted system call I'm quite sure that the "interrupted system call" is just a red herring: errno is set to an old value and it's not the cause why wresize failed (which is probably an invalid size.) > > only slightly related, but I was thinking of trying to drop the panel > > library in tog now that we're properly resizing the windows for the > > splits. (before it was needed because the child window was rendered _on > > top_ of the main one, that's not the case anymore.) > > That's ok with me. Considering we only go one child deep, there > shouldn't be too much surgery. I don't know if you want to do this now > or leave it till after we get hsplits sorted? it was just an idea that it was floating in my head before and wanted to hear what you were thinking about it too. no rush thought, better fix and get the hsplit working first! :)