From: Stefan Sperling Subject: Re: tog: fix log view 'd' keymap when less than nlines/2 from the last commit To: Mark Jamsek Cc: Omar Polo , gameoftrees@openbsd.org Date: Fri, 12 Aug 2022 14:14:26 +0200 On Fri, Aug 12, 2022 at 09:22:31PM +1000, Mark Jamsek wrote: > On 22-08-12 12:24PM, Omar Polo wrote: > > the diff reads fine, however I'm a bit confused. With your patch > > applied when I'm at the end of the logs `d' moves selection down, but > > otherwise it *scrolls* the page. Before, it always scrolled. > > > > Which one is the correct behaviour? > > Yes, this change is deliberate and it was actually the previous > behaviour before we added hsplits. If you checkout > c71ed39a66ed8e3aeaa13e76fce179b7bf6efec6 you'll see it behaves the same > as this diff proposes. I also think it's a smoother experience too so am > a little biased :) Agreed, this behaviour makes sense. ok stsp@