From: Stefan Sperling <stsp@stsp.name>
Subject: Re: tog: simplify log_move_cursor_down()
To: Mark Jamsek <mark@jamsek.com>
Cc: Game of Trees <gameoftrees@openbsd.org>
Date: Fri, 12 Aug 2022 14:16:28 +0200

On Fri, Aug 12, 2022 at 09:20:10PM +1000, Mark Jamsek wrote:
> This stems from Mikhail's observation yesterday in the tog log 'd' key
> map thread.
> 
> In the log view 'G' key map case, we would first check if the currently
> displayed page already contains the last commit and, if so, jump to it.
> Otherwise we would scroll down to the last page and then move the
> selection cursor to the last commit. However, we were still handling the
> 'G' case when the commit history had already been loaded (i.e.,
> thread_args.log_complete) in input_log_view(), which is always the case
> when the last commit is already on the displayed page, so the check was
> superfluous! The below diff moves the latter 'G' case into
> log_move_cursor_down(), and simplifies this routine's handling of 'G' by
> handling both cases the same: set the last displayed commit to the last
> commit in the log and walk back. I think this reads nicer and
> consolidates all downward log cursor movement into one place.
> 
> ok?
> 
> btw this diff applies on top of the other tog log diff that fixes the
> 'd' key map.

ok stsp@