From: Stefan Sperling Subject: Re: gotwebd: introducing fcgi_printf To: Mark Jamsek Cc: Omar Polo , gameoftrees@openbsd.org, Tracey Emery Date: Mon, 15 Aug 2022 14:59:08 +0200 On Mon, Aug 15, 2022 at 09:46:38PM +1000, Mark Jamsek wrote: > (1) I noticed in the diff lib we use the gcc extension to omit the > middle operand in ternary ifs in quite a few places. I just did > a cursory scan of got and couldn't see it elsewhere _except_ it is > used in gotwebd/got_operations.c. I'm not sure if you or stsp have > a preference either way, but there are a few opportunities for it > in this diff so thought I'd mention it. We should not use this extension. I recall this extension coming up before (perhaps in the diff.git code?) and being kicked out again. Generally, if a compiler extension is not in use by the OpenBSD base system then Got should avoid it, too.