From: Stefan Sperling <stsp@stsp.name>
Subject: Re: gotwebd crash in got_gotweb_blame_cb
To: Omar Polo <op@omarpolo.com>, gameoftrees@openbsd.org
Date: Thu, 18 Aug 2022 17:09:07 +0200

On Thu, Aug 18, 2022 at 08:46:10AM -0600, Tracey Emery wrote:
> Try this. I think stsp just had it reversed.

> diff /home/tracey/src/got
> commit - bf80b15220f51490025e916633cdd70816113604
> path + /home/tracey/src/got
> blob - 39827e91edca9da87bdc0ce98c9a77260b22dd4e
> file + got/got.c
> --- got/got.c
> +++ got/got.c
> @@ -5368,7 +5368,7 @@ blame_cb(void *arg, int nlines, int lineno,
>  		goto done;
>  	}
>  
> -	while (bline->annotated) {
> +	while (a->lineno_cur <= a->nlines && bline->annotated) {
>  		char *smallerthan, *at, *nl, *committer;
>  		size_t len;
> 

Whoops, indeed. Ok stsp@ for this correct fix :)