From: Tom Jones <thj@freebsd.org>
Subject: Re: diff.git: Fix ed script output
To: gameoftrees@openbsd.org
Date: Tue, 6 Sep 2022 16:14:20 +0100

On Tue, Sep 06, 2022 at 04:46:45PM +0200, Stefan Sperling wrote:
> On Tue, Sep 06, 2022 at 01:33:37PM +0100, Tom Jones wrote:
> > The rc check is happening in the look twice, once for diff_output_lines
> > and once for the fprintf, so it doesn't need to happen here again.
> > 
> > I have removed that and made the check for printf to be < 0.
> 
> This patch looks very good to me.
> 
> However, it breaks a regression test. Can you reproduce this failure?
> And, if so, do you have time to figure out why it breaks?
> 
> $ make -C test
> [...]
> cmp: EOF on expect123.diff
> FAIL: verify.expect123.diff != expect123.diff
> OK: arraylist_test
> OK: results_test
> 
> Tests failed:
> FAIL: verify.expect123.diff != expect123.diff
> *** Error 1 in /home/stsp/src/diff/test (Makefile:7 'verify')
> $

I get this failure on an unpatched repo too. I'll have a look into it.

- Tom