From: Stefan Sperling <stsp@stsp.name>
Subject: Re: faster reuse of deltas
To: Omar Polo <op@omarpolo.com>
Cc: gameoftrees@openbsd.org
Date: Sat, 3 Dec 2022 17:38:20 +0100

On Sat, Dec 03, 2022 at 05:28:54PM +0100, Omar Polo wrote:
> > @@ -1519,7 +1519,8 @@ got_repo_pin_pack(struct got_repository *repo, struct 
> >  
> >  	repo->pinned_pack = pinned_pack;
> >  	repo->pinned_packidx = pinned_packidx;
> > -	repo->pinned_pid = repo->packs[pinned_pack].privsep_child->pid;
> > +	if (repo->packs[pinned_pack].privsep_child)
> > +		repo->pinned_pid = repo->packs[pinned_pack].privsep_child->pid;
> >  	return NULL;
> >  }
> 
> not an issue, but I'm not sure about the rationale for this hunk in
> this diff.

This code path is also traversed by gotd's repo_read, where no
privsep child exists.

> > blob - e49fd95ba0b7919efe9005b306782db008b22370
> > blob + a86f3dde84274fdf37db09da580f7bba1e012e46
> > --- libexec/got-read-pack/got-read-pack.c
> > +++ libexec/got-read-pack/got-read-pack.c
> > [...]
> > @@ -1054,7 +1045,7 @@ delta_reuse_request(struct imsg *imsg, struct imsgbuf 
> >  
> >  static const struct got_error *
> >  delta_reuse_request(struct imsg *imsg, struct imsgbuf *ibuf,
> > -    FILE *delta_outfile, struct got_pack *pack, struct got_packidx *packidx)
> > +	struct got_pack *pack, struct got_packidx *packidx)
> 
> tabs when should use four spaces

Fixed, thanks!