From: Omar Polo <op@omarpolo.com>
Subject: Re: faster reuse of deltas
To: Stefan Sperling <stsp@stsp.name>
Cc: gameoftrees@openbsd.org
Date: Sat, 03 Dec 2022 18:22:57 +0100

On 2022/12/03 17:38:20 +0100, Stefan Sperling <stsp@stsp.name> wrote:
> On Sat, Dec 03, 2022 at 05:28:54PM +0100, Omar Polo wrote:
> > > @@ -1519,7 +1519,8 @@ got_repo_pin_pack(struct got_repository *repo, struct 
> > >  
> > >  	repo->pinned_pack = pinned_pack;
> > >  	repo->pinned_packidx = pinned_packidx;
> > > -	repo->pinned_pid = repo->packs[pinned_pack].privsep_child->pid;
> > > +	if (repo->packs[pinned_pack].privsep_child)
> > > +		repo->pinned_pid = repo->packs[pinned_pack].privsep_child->pid;
> > >  	return NULL;
> > >  }
> > 
> > not an issue, but I'm not sure about the rationale for this hunk in
> > this diff.
> 
> This code path is also traversed by gotd's repo_read, where no
> privsep child exists.

Right, obvious, i should have seen that, sorry.