From: Omar Polo <op@omarpolo.com>
Subject: Re: gotwebd: templateify gotweb_render_diff
To: Omar Polo <op@omarpolo.com>
Cc: gameoftrees@openbsd.org
Date: Fri, 06 Jan 2023 19:29:36 +0100

On 2023/01/06 09:33:26 +0100, Omar Polo <op@omarpolo.com> wrote:
> To avoid calling functions from got_operations.c directly from a
> template (which would hide the error), change got_output_repo_diff
> into got_open_diff_for_output that returns a file with the diff in it,
> to be then rendered by the template.  got_gotweb_flushfile needs to be
> exposed then.
> 
> It also bundles a smaller change: the `label' argument of
> got_repo_match_object_id is optional and not used, so just pass NULL
> there.
> 
> note that this requires a tweak to the template I just committed.
> (add while loops) so remember to `make -C template' if not running
> `make webd' from the top-level directory.

I ended up pushing this too by mistake when committing the changes to
the template manpages.  i've backed it out, sorry.