From: Stefan Sperling <stsp@stsp.name>
Subject: Re: got: add diffstat to got diff
To: Mark Jamsek <mark@jamsek.com>
Cc: Game of Trees <gameoftrees@openbsd.org>
Date: Mon, 9 Jan 2023 10:06:42 +0100

On Mon, Jan 09, 2023 at 07:19:55PM +1100, Mark Jamsek wrote:
> We free entry members often enough that I would even like
> either a boolean in the existing got_pathlist_free() routine to
> optionally free members, or perhaps another got_pathlist_free_all()
> routine that also frees each entry's members; then we could save the
> extra loop. If you think that's worthwhile, that would be another diff
> though. For now I'll drop the redundant call and do another loop.

Yes, allowing callers of got_pathlist_free() to specify whether
the path and/or data pointers are safe to free sounds like a good
idea. This should reduce the room for mistakes a little.