From: Omar Polo <op@omarpolo.com>
Subject: Re: zap dead variable in got.c:add_branch()
To: Mark Jamsek <mark@jamsek.com>
Cc: Game of Trees <gameoftrees@openbsd.org>
Date: Tue, 10 Jan 2023 13:04:34 +0100

On 2023/01/10 22:58:56 +1100, Mark Jamsek <mark@jamsek.com> wrote:
> As per the subject, this looks like a holdover no longer being used.

ok

> diff 75b17c2a7d14fc0476cba0375a5a031cf0c13a00 refs/heads/main
> commit - 75b17c2a7d14fc0476cba0375a5a031cf0c13a00
> commit + 14048173ff560be5e9c163faf15d37e2130ef00a
> blob - 7f294d2ed40076ca1dedf56ff7581a9d161936e6
> blob + 5e95ca3316302472e74abae334031fd6835220aa
> --- got/got.c
> +++ got/got.c
> @@ -6800,7 +6800,7 @@ add_branch(struct got_repository *repo, const char *br
>  {
>  	const struct got_error *err = NULL;
>  	struct got_reference *ref = NULL;
> -	char *base_refname = NULL, *refname = NULL;
> +	char *refname = NULL;
>  
>  	/*
>  	 * Don't let the user create a branch name with a leading '-'.
> @@ -6833,7 +6833,6 @@ done:
>  done:
>  	if (ref)
>  		got_ref_close(ref);
> -	free(base_refname);
>  	free(refname);
>  	return err;
>  }