From: Omar Polo <op@omarpolo.com>
Subject: Re: got: cleanup failure leaks and set error on asprintf() failure
To: Mark Jamsek <mark@jamsek.com>
Cc: Game of Trees <gameoftrees@openbsd.org>
Date: Wed, 11 Jan 2023 12:15:02 +0100

On 2023/01/11 21:54:07 +1100, Mark Jamsek <mark@jamsek.com> wrote:
> As per the subject, the following two diffs perform some minor
> housekeeping.
> 
> First are some failure leaks spotted while implementing diffstat in
> lib/diff.c (some of which were also observed by op whose idea I went
> with instead of the original fix to free at every error return).
> 
> The second is catching a couple instances I missed in got.c:cmd_diff()
> where error isn't set on asprintf() failure even though we goto done.
> 
> ok?

ok op@ for both

thanks!