From: Omar Polo <op@omarpolo.com>
Subject: Re: gotwebd: bubble up got_get_repo_tags
To: Omar Polo <op@omarpolo.com>
Cc: gameoftrees@openbsd.org
Date: Thu, 12 Jan 2023 13:08:07 +0100

On 2023/01/12 12:26:41 +0100, Omar Polo <op@omarpolo.com> wrote:
> @@ -310,11 +309,13 @@ render:
>  			goto done;
>  		break;
>  	case TAGS:
> -		error = gotweb_render_tags(c);
> +		error = got_get_repo_tags(c, srv->max_commits_display);
>  		if (error) {
>  			log_warnx("%s: %s", __func__, error->msg);
> -			goto err;
> +			goto done;
>  		}

copy-paste error.  this should have remained `goto err' to display a
proper page.  (I have mistaken some goto err/done in this function
already, but don't introduce more.)  Fixed locally.

> +		if (gotweb_render_tags(c->tp) == -1)
> +			goto done;
>  		break;
>  	case TREE:
>  		error = got_get_repo_commits(c, 1);