From: Omar Polo <op@omarpolo.com>
Subject: Re: gotwebd: templatefy gotweb_render_blame
To: Mark Jamsek <mark@jamsek.com>
Cc: gameoftrees@openbsd.org
Date: Sun, 15 Jan 2023 09:19:39 +0100

On 2023/01/15 16:26:42 +1100, Mark Jamsek <mark@jamsek.com> wrote:
> On 23-01-13 09:47AM, Omar Polo wrote:
> > finally, at least :)
> 
> Nice :)
> 
> > Had to move `struct blame_line' to the header for it to be visible and
> > typedef the callback because was painful to type.
> > 
> > no functional change intended.
> > 
> > ok?
> 
> ok with or without the following tiny style nit.
> 
> Please consider prefixing the `render_blame_line_fn` typedef with
> "got_", and using the existing "_cb" suffix convention for callbacks:
> 
> typedef int (*got_render_blame_line_cb)(struct template *, const char *,
>     struct blame_line *, int, int);

Agreed, I've committed with this fixed, thanks!