From: Stefan Sperling <stsp@stsp.name>
Subject: Re: refactor diffstat to compute diff once in got log -d and tog diff view
To: Mark Jamsek <mark@jamsek.com>
Cc: Game of Trees <gameoftrees@openbsd.org>
Date: Tue, 17 Jan 2023 09:40:05 +0100

On Tue, Jan 17, 2023 at 06:19:43PM +1100, Mark Jamsek wrote:
> I agree on all counts; I wasn't too sure about that change so really
> appreciate your feedback. Thanks!

:)

> Updated diff keeps existing behaviour for `got log -d` (i.e., only the
> diffstat is displayed); however, it has been optimised slightly such
> that when `got log -dp` is invoked, we now only compute the diff once.
> The downside is there's no longer an appreciable net LOC decrease.
> 
> Nonetheless, this eliminates the double-diff-computation performance
> cost in tog and 'got log' wrt displaying the diffstat with the diff :)

Thanks, and now I've also found time to read through. ok stsp@