From: Stefan Sperling <stsp@stsp.name>
Subject: Re: gotd: handle early client disconnections
To: Mark Jamsek <mark@jamsek.com>
Cc: Omar Polo <op@omarpolo.com>, gameoftrees@openbsd.org
Date: Mon, 23 Jan 2023 08:55:46 +0100

On Mon, Jan 23, 2023 at 04:09:29PM +1100, Mark Jamsek wrote:
> On 23-01-22 02:50PM, Omar Polo wrote:
> > On 2023/01/23 00:08:40 +1100, Mark Jamsek <mark@jamsek.com> wrote:
> > > On 23-01-22 12:48PM, Omar Polo wrote:
> > > >  	if (strcmp(command, GOT_SERVE_CMD_FETCH) == 0)
> > > >  		err = serve_read(infd, outfd, gotd_sock, repo_path, chattygot);
> > > >  	else if (strcmp(command, GOT_SERVE_CMD_SEND) == 0)
> > > > -		err = serve_write(infd, outfd, gotd_sock, repo_path, chattygot);
> > > > +		err = serve_write(infd, outfd, gotd_sock, repo_path,
> > > > +		    chattygot);
> > > 
> > > I can't see why the line has been wrapped; chattygot fits on the above
> > > line?
> > 
> > the above line is 79 columns, that was 80 :)
> 
> Oh whoops, I've been doing it wrong! I always thought it was [1,80] not
> [1,80)  :)

style(9) says "All code should fit in 80 columns."
I don't know if that includes code in diffs which has an extra column
at the beginning. I usually try to wrap at less than 80 but there are
cases where I just let run up to 80. In any case, not a big deal.