From: Omar Polo Subject: Re: tog: fix some OB1s in view rendering To: Mark Jamsek Cc: Game of Trees Date: Wed, 01 Feb 2023 09:11:05 +0100 On 2023/02/01 18:09:05 +1100, Mark Jamsek wrote: > I noticed an off-by-one error by chance when perusing old backup refs. > To reproduce, reduce the width of your terminal to a width that is just > one column greater than a given ref entry string (this can be lengthened > by toggling 'i' and 'm'), and notice we don't insert '\n' at the end of > the ref string so the next entry begins on the same line and wraps > around. > > I figured there's a good chance we do this elsewhere, and found the same > problem in our tree view. Reduce screen width to 30 columns and > navigate to: > > "/gotwebd/files/htdocs/gotwebd/android-chrome-192x192.png" > > and observe how the next file (android-chrome-384x384.png) starts at the > end of this entry and wraps to the next line. > > While not quite the same problem, I noticed we weren't drawing to the > last column in our help view, so the diff makes a small change here too. > > ok? agreed, and works as expected. ok op@ thanks!