From: Omar Polo <op@omarpolo.com>
Subject: Re: gotd broken tree
To: Mark Jamsek <mark@jamsek.com>
Cc: Game of Trees <gameoftrees@openbsd.org>
Date: Mon, 06 Feb 2023 14:31:32 +0100

On 2023/02/07 00:08:40 +1100, Mark Jamsek <mark@jamsek.com> wrote:
> The gotd build appears to be broken at the moment:
> 
> ----8<--------
>   $ make server
>   ...
>   cc -O0 -g  -o gotctl gotctl.o error.o imsg.o pollfd.o sha1.o -lutil -lz -lm -levent
>   ld: error: undefined symbol: got_object_id_hex
>   >>> referenced by error.c:374 (/home/mark/src/got/gotctl/../lib/error.c:374)
>   >>>               error.o:(got_error_no_obj)
>   >>> referenced by error.c:391 (/home/mark/src/got/gotctl/../lib/error.c:391)
>   >>>               error.o:(got_error_checksum)
>   cc: error: linker command failed with exit code 1 (use -v to see invocation)
>   *** Error 1 in gotctl (<bsd.prog.mk>:126 'gotctl')
>   *** Error 2 in /home/mark/src/got (Makefile:49 'server')
> -------->8----
> 
> The below diff seems to produce a clean build, with both regress/cmdline
> and regress/gotd passing.

Oops, sorry, I forgot (again) to build everything after a change.  I
knew that there were two got_repo_read_gitconfig implementations but
only tweaked one :(

will pay more attention in the future; thanks for fixing the issue! :)