From: Stefan Sperling <stsp@stsp.name>
Subject: Re: got patch: Result too large
To: Omar Polo <op@omarpolo.com>
Cc: Christian Weisgerber <naddy@mips.inka.de>, gameoftrees@openbsd.org
Date: Tue, 7 Feb 2023 16:43:13 +0100

On Tue, Feb 07, 2023 at 04:31:08PM +0100, Omar Polo wrote:
> Now, sending the (parsed) lines of the diff via imsg one at a time is
> not a great idea.  It is like this because I wanted to have the
> parsing in a separate helper (everything got parses is in a separate
> helper, would seem strange to hadle patches in the main process,
> although they're trivial to parse.)  Maybe i should set up a pipe or a
> temp file between the two processes and just send the offsets via
> imsg.  could even batch like we're doing with the tree entries.

Or you could send the entire parsed content in imsg-sized chunks,
rather than lines. Like commit log messages are transferred over imsg.

Large patches like this are rare so I would not worry about optimizing
things specifically for them.