From: Stefan Sperling <stsp@stsp.name>
Subject: Re: got patch: Result too large
To: Omar Polo <op@omarpolo.com>
Cc: Christian Weisgerber <naddy@mips.inka.de>, gameoftrees@openbsd.org
Date: Tue, 7 Feb 2023 17:04:11 +0100

On Tue, Feb 07, 2023 at 04:47:50PM +0100, Omar Polo wrote:
> actually it's worse.  patch fails due to:
> 
> patch: **** malformed patch at line 392134: RCS file: gnu/usr.bin/perl/cpan/IO-Compress/t/files/testfile1.odt
> 
> and that's a... odt?  it's a binary files with various NUL bytes in
> it.
> 
> 	-^@...
> 	+^@...
> 
> got-read-patch is currently using strlen in send_line so that would
> silently fails, thinking it had applied the correct when it didn't.
> 
> adding this too to my todo list.

I would not trust CVS to generate a diff for such files that would
actually have any meaning. Someone forgot to pass -kb to 'cvs add'.