From: Stefan Sperling Subject: Re: abort commit if merged log messages are left as-is To: Christian Weisgerber Cc: gameoftrees@openbsd.org Date: Thu, 9 Feb 2023 22:13:54 +0100 On Thu, Feb 09, 2023 at 10:03:37PM +0100, Christian Weisgerber wrote: > Stefan Sperling: > > > > Oh, the log message must be actually modified? Can't you just > > > compare mtime before/after, > > > > There would be no way to reverse your decision to commit once the > > timestamp has been changed. But I guess that is fine. > > The commit is aborted if > * the time stamp of the log message hasn't changed, or > * the log message is empty. > > Is that practical? Yes, I believe so. In particular because this behaviour is easy to explain and understand. And, of course, "empty" means: empty with comments removed