From: Mark Jamsek Subject: Re: tog: cycle a searches and movements To: Christian Weisgerber Cc: Mikhail , gameoftrees@openbsd.org Date: Sat, 11 Feb 2023 12:02:46 +1100 On 23-02-10 10:36PM, Christian Weisgerber wrote: > Mikhail: > > > This patch introduces cycle searches/movement customization through > > TOG_CYCLE_MOVEMENT environment variable, when set - all searches and > > movements inside diff view will cycle, when it's NULL - we will stop > > after last match. > > Now that we have "action reports", it would be nice to have one > when the search cycles. I'm not fond of configuration by environment > variables. Yes, I agree with naddy. Like vi(1) and mutt(1), a "search wrapped" report would be a good idea when we wrap search in the diff view. And, if the same behaviour is added to the log view--which makes sense to me as we already do this in all the other views plus it's also somewhat standard behaviour in apps like vi and mutt--the same report would be good there too. I don't know if it would make as much sense with the () and {} keymaps as, while technically a search, I don't really think about it like that, but for simplicity's sake, just reuse the same string (i.e., "search wrapped") in those cases too. In any case, I don't think the proposed diff is right, but it would be great if you felt like implementing naddy's suggestion! And, if you still had the energy, write a diff to make log search wrap so rather than the "no more matches" report, you get "search wrapped" instead. If not, let me know, and I'll take a stab at making log search wrap :) -- Mark Jamsek GPG: F2FF 13DE 6A06 C471 CA80 E6E2 2930 DC66 86EE CF68