From: Stefan Sperling <stsp@stsp.name>
Subject: Re: got-build-regress.sh regress failure
To: gameoftrees@openbsd.org
Date: Thu, 23 Feb 2023 22:02:45 +0100

On Thu, Feb 23, 2023 at 08:09:36PM +0100, stsp@stsp.name wrote:
> got-build-regress.sh for branch 'main' on Thu Feb 23 19:00:05 UTC 2023

> 	 Test failures:
> 
> test failed; leaving test data in /tmp/got-test-send_basic-rhPNntfS
> test failed; leaving test data in /tmp/got-test-send_rebase_required_overwrite-dkRUWyiD
> test failed; leaving test data in /tmp/got-test-send_clone_and_send-F2vgxjip
> test failed; leaving test data in /tmp/got-test-send_tags-nSQaxYf1
> test failed; leaving test data in /tmp/got-test-send_tag_of_deleted_branch-pgx0AJdw
> test failed; leaving test data in /tmp/got-test-send_new_branch-9qYcYPyN
> test failed; leaving test data in /tmp/got-test-send_all_branches-5GIyAd18
> test failed; leaving test data in /tmp/got-test-send_to_empty_repo-3IGdr483
> test failed; leaving test data in /tmp/got-test-send_fetch_conf-wEmuXCzh
> test failed; leaving test data in /tmp/got-test-send_rejected-ZzM7QgqI
> test failed; leaving test data in /tmp/got-test-pack_all_loose_objects-KuyETfyX
> test failed; leaving test data in /tmp/got-test-pack_exclude-g2ecMOCA
> test failed; leaving test data in /tmp/got-test-pack_exclude_tag-riOPdXV5
> test failed; leaving test data in /tmp/got-test-pack_include-CwxDvsYl
> test failed; leaving test data in /tmp/got-test-pack_loose_only-LrbeWZBr
> test failed; leaving test data in /tmp/got-test-pack_all_objects-FYJkNgk4
> test failed; leaving test data in /tmp/got-test-cleanup_redundant_loose_objects-EKg7KU22
> test failed; leaving test data in /tmp/got-test-cleanup_missing_pack_file-GlglMA5p
> 
> 

Should be fixed with this commit:


-----------------------------------------------
commit 017d8b7bf9006ae1bc36f6b1a38978f2782b363f (main, origin/main)
from: Stefan Sperling <stsp@stsp.name>
date: Thu Feb 23 21:01:32 2023 UTC
 
 properly initialize csum struct in write_packed_object()
 
 fixes send.sh test fallout on arm64 and should also fix i386
 
 ok op@
 
diff 14f89e3e5394e931edf4581cfb229beef1de3f41 017d8b7bf9006ae1bc36f6b1a38978f2782b363f
commit - 14f89e3e5394e931edf4581cfb229beef1de3f41
commit + 017d8b7bf9006ae1bc36f6b1a38978f2782b363f
blob - 7b9d8ec82cf5ba8c697ed65bfab03a59ac4cabe8
blob + a467a2aec8f4b84bb79456886304f79f16160ad4
--- lib/pack_create.c
+++ lib/pack_create.c
@@ -1601,8 +1601,8 @@ write_packed_object(off_t *packfile_size, int packfd,
 	struct got_raw_object *raw = NULL;
 	off_t outlen, delta_offset;
 
+	memset(&csum, 0, sizeof(csum));
 	csum.output_ctx = ctx;
-	csum.output_crc = NULL;
 
 	if (m->reused_delta_offset)
 		delta_offset = m->reused_delta_offset;