From: Stefan Sperling <stsp@stsp.name>
Subject: Re: dial fix for git-shell
To: Omar Polo <op@omarpolo.com>
Cc: gameoftrees@openbsd.org
Date: Fri, 10 Mar 2023 14:43:45 +0100

On Fri, Mar 10, 2023 at 11:36:27AM +0100, Omar Polo wrote:
> On 2023/03/08 19:58:48 +0100, Stefan Sperling <stsp@stsp.name> wrote:
> > Given your explanation above I am fine with your diff.
> > 
> > It would be nice to have a test case for a rock'n'roll repo and perhaps
> > even one that uses git-shell? Perhaps git-shell would best be done in
> > the gotd test suite since we there is more manual setup required for those
> > already. We could require yet another user account which uses git-shell
> > as its login shell and run some tests against it. I will look into this.
> 
> There was an embarassing omission in my previous diff... The
> un-escaped path was passed in the argv and caused a bit of headache ^^"
> 
> Here's an improved diff that also adds a simple clone test.  it only
> ensures we're still quoting it decently for the remote shell, it
> doesn't involve git-shell.

Ok, thanks! Based on prior testing I believe this will make git-shell happy.