From: Mark Jamsek <mark@jamsek.com>
Subject: Re: crash in 'got log' (no reliable way to reproduce)
To: Omar Polo <op@omarpolo.com>
Cc: Mikhail <mp39590@gmail.com>, gameoftrees@openbsd.org
Date: Sun, 2 Apr 2023 11:39:21 +1000

On 23-04-01 04:53PM, Omar Polo wrote:
> re-trying (hopefully) without quoted-printable ;-)

ok

> 
> diff -s /home/op/w/got
> commit - f9b5f5fbdf2ae49a4e217212d261d89d83dacd7e
> path + /home/op/w/got (staged changes)
> blob - a51a450a06ab2800d2fe4a200fc31cc59364dac6
> blob + 8ff7e074110ce8eb022c3fee11169b99a0e583fe
> --- got/got.c
> +++ got/got.c
> @@ -3708,7 +3708,8 @@ done:
>  		got_object_blob_close(blob1);
>  	if (fd2 != -1 && close(fd2) == -1 && err == NULL)
>  		err = got_error_from_errno("close");
> -	got_object_blob_close(blob2);
> +	if (blob2)
> +		got_object_blob_close(blob2);
>  	if (f1 && fclose(f1) == EOF && err == NULL)
>  		err = got_error_from_errno("fclose");
>  	if (f2 && fclose(f2) == EOF && err == NULL)
> 

-- 
Mark Jamsek <fnc.bsdbox.org|got.bsdbox.org>
GPG: F2FF 13DE 6A06 C471 CA80  E6E2 2930 DC66 86EE CF68