From: Christian Weisgerber <naddy@mips.inka.de>
Subject: Re: tog test harness
To: gameoftrees@openbsd.org
Date: Tue, 18 Apr 2023 16:53:04 +0200

Mark Jamsek:

> IIRC, this was a hueristic used to determine whether tog was being run
> in the console because there they are rendered as '?' so we use | and
> - instead.

I see.

The problem is setting TERM on the console to a terminal type whose
description advertises support for the alternate charset capability,
when the console doesn't actually support it.  That's a problem of
wscons(4).  Applications can't be expected to work around that.

So as a first step I suggest removing this bizarre workaround:

------------------->
--- tog/tog.c
+++ tog/tog.c
@@ -982,11 +982,10 @@ view_border(struct tog_view *view)
 	view_above = panel_userptr(panel);
 	if (view->mode == TOG_VIEW_SPLIT_HRZN)
 		mvwhline(view->window, view_above->begin_y - 1,
-		    view->begin_x, got_locale_is_utf8() ?
-		    ACS_HLINE : '-', view->ncols);
+		    view->begin_x, ACS_HLINE, view->ncols);
 	else
 		mvwvline(view->window, view->begin_y, view_above->begin_x - 1,
-		    got_locale_is_utf8() ? ACS_VLINE : '|', view->nlines);
+		    ACS_VLINE, view->nlines);
 }
 
 static const struct got_error *view_init_hsplit(struct tog_view *, int);
<-------------------

Alternatively, of course, we could drop the use of ACS_* and always
use ASCII characters.

Then the screendump issue can be revisited.  I think the overwriting
of vline/hline should be removed, too.

-- 
Christian "naddy" Weisgerber                          naddy@mips.inka.de