From: Stefan Sperling <stsp@stsp.name>
Subject: Re: tog: teach test harness to count and basic tree test
To: Mark Jamsek <mark@jamsek.com>
Cc: Game of Trees <gameoftrees@openbsd.org>
Date: Thu, 20 Apr 2023 12:52:06 +0200

On Thu, Apr 20, 2023 at 05:40:02PM +1000, Mark Jamsek wrote:
> The below diff teaches the tog test harness to read count modifier
> instructions, and adds basic tree view regress tests--one of which
> demonstrates the count mod instruction.
> 
> It applies on top of pending diffs: (1) naddy's tweaks to drop the
> SCREENDUMP defines, unset TOG_* and set TERM=vt220 envvars, and
> unconditionally write | and -; and (2) stsp's improvements for the wait
> instruction to use pthread conditions (this has been tweaked since the
> previous revision by renaming and making the pthread_cond_t condition
> a member of the blame thread_args structure instead).
> 
> The diff might apply cleanly without them, and the tree/blame split view
> regress may even work without (2), but just in case they are also
> attached below for convenience.

All this is looking great to me. ok.