From: Omar Polo <op@omarpolo.com>
Subject: Re: [patch] regress/cmdline: fix handling of unexpected success
To: James Cook <falsifian@falsifian.org>
Cc: gameoftrees@openbsd.org
Date: Sat, 17 Jun 2023 23:54:43 +0200

On 2023/06/17 19:05:35 +0000, James Cook <falsifian@falsifian.org> wrote:
> There are many places in the regress/cmdline scripts where a result of
> "0" is passed to test_done when a command succeeded unexpectedly. For
> example:
> 
> 	if [ $ret -eq 0 ]; then
> 		echo "got merge succeeded unexpectedly" >&2
> 		test_done "$testroot" "$ret"
> 		return 1
> 	fi
> 
> The below patch is intended to fix those. Note that I barely tested this
> patch: (a) verified the scripts all still pass, and (b) introduced one
> bug and verified the test script responded appropriately, saying
> "leaving test data in ..." instead of "ok" as it did before.

I remember doing a sweep some time ago.  I probably missed some, or
they were re-introduced afterwards.

Committed, thanks!