From: Stefan Sperling <stsp@stsp.name>
Subject: Re: plug got_object_id leak in got.c:cmd_log()
To: Mark Jamsek <mark@jamsek.com>
Cc: gameoftrees@openbsd.org
Date: Mon, 10 Jul 2023 19:31:27 +0200

On Tue, Jul 11, 2023 at 02:04:58AM +1000, Mark Jamsek wrote:
> As per the subject: plug a couple object id leaks spotted while working
> on something else.

ok

> -----------------------------------------------
> commit 7ac95b7e97ab3abe2942c3f5558f3f54e33c165b (main)
> from: Mark Jamsek <mark@jamsek.dev>
> date: Mon Jul 10 15:58:04 2023 UTC
>  
>  plug got_object_id leak in cmd_log()
>  
> diff 0d23c640a51b599b99c9fe781c54e1bd371bc433 7ac95b7e97ab3abe2942c3f5558f3f54e33c165b
> commit - 0d23c640a51b599b99c9fe781c54e1bd371bc433
> commit + 7ac95b7e97ab3abe2942c3f5558f3f54e33c165b
> blob - 33fa9d308c2a4c7ed10e872de41279f2c5ba44bc
> blob + 01fe4299c82e150fcd8020915536f48fc73bacbc
> --- got/got.c
> +++ got/got.c
> @@ -4789,6 +4789,8 @@ done:
>  	free(path);
>  	free(repo_path);
>  	free(cwd);
> +	free(start_id);
> +	free(end_id);
>  	if (worktree)
>  		got_worktree_close(worktree);
>  	if (repo) {
> 
> 
> -- 
> Mark Jamsek <https://bsdbox.org>
> GPG: F2FF 13DE 6A06 C471 CA80  E6E2 2930 DC66 86EE CF68
>