From: Stefan Sperling Subject: Re: [PATCH] got histedit: make mesg behave like pick To: gameoftrees@openbsd.org Date: Tue, 24 Oct 2023 17:14:37 +0200 On Tue, Oct 24, 2023 at 03:47:56PM +0200, Lorenz (xha) wrote: > i realize now that this has a bug: > > ``` > mesg > edit > ``` > > it will open the editor at least twice to edit the same commit message > (for the `mesg` command). this is because we now parse the histedit > script two times: > - when intially closing the editor that had the histedit script open > - when continuing the edit using `histedit -c` > > there is no way to save the log message without completly changing how > histedit works afaik... Since 'edit' implies 'mesg' I see no semantic reason why both would be needed together. With 'mesg ' becoming a valid histedit instruction, I would expect that your example is now an invalid histedit script. Because a given commit may only be listed once.