From: Omar Polo <op@omarpolo.com>
Subject: Re: get rid of got_sockaddr.[ch]
To: gameoftrees@openbsd.org
Date: Wed, 15 Nov 2023 14:40:45 +0100

On 2023/11/15 14:31:19 +0100, Omar Polo <op@omarpolo.com> wrote:
> These were added due to gotwebd weird struct sockaddr_storage handling.
> Instead, we can save the size reported by getaddrinfo() and not reach
> into the struct sockaddr storage at all (except for extracting the port
> number for diagnostics purposes.)

I forgot to elaborate a point here: I know that got_sockaddr.[ch] were
added to aid -portable, but with these changes I believe it should work
as-is without changes for -portable.  At least, I have some code using
this that works on OpenBSD, FreeBSD and linux.

> sockets_conf_new_socket_fcgi() gets an hardcoded ipproto to 0 at the
> moment, and for the moment keeps the hardcoded SOCK_STREAM.  cleaning up
> this function will be the next step.