From: Stefan Sperling <stsp@stsp.name>
Subject: Re: gotwebd: guard against missing qs->file
To: Omar Polo <op@omarpolo.com>
Cc: gameoftrees@openbsd.org
Date: Tue, 30 Jan 2024 11:24:37 +0100

On Tue, Jan 30, 2024 at 10:49:47AM +0100, Omar Polo wrote:
> On 2024/01/29 14:59:45 +0100, Stefan Sperling <stsp@stsp.name> wrote:
> > On Mon, Jan 29, 2024 at 02:52:04PM +0100, Omar Polo wrote:
> > > I can remove the qs->folder check if you prefer.
> > 
> > Please remove it from the other place instead.
> > 
> > Overall, I would prefer to keep input validation checks in one place.
> > That makes it easier to spot problems where such checks are missing.
> > 
> > So when adding the qs->folder check at this higher level please remove it
> > from the lower level so that we converge towards eventual consistency.
> 
> sorry for the delay, here's the updated diff.

Thanks, ok!