From: Omar Polo <op@omarpolo.com>
Subject: Re: fix use of uninitialized variable in update_blob
To: Stefan Sperling <stsp@stsp.name>
Cc: gameoftrees@openbsd.org
Date: Tue, 13 Feb 2024 21:05:42 +0100

On 2024/02/13 20:53:05 +0100, Stefan Sperling <stsp@stsp.name> wrote:
> On Tue, Feb 13, 2024 at 08:18:57PM +0100, Omar Polo wrote:
> > both update_timestamps may be used un-initalized.
> 
> You mean in the case where status is something other than
> add/modify/delete and S_ISLNK(te->mode)) is true and ie is NULL?
> I am not sure when this combination of conditions will happen in practice.

neither do I, but it's super-confusing to shadow one variable in the
nested if and while this uninitialized access may not happen right now
and we may rearrange the code in the future without noticing.  (even if,
in this case, it's mostly harmless to even update_timestamps if
uninitialized)