From: Omar Polo <op@omarpolo.com>
Subject: Re: gotd notification support
To: Stefan Sperling <stsp@stsp.name>
Cc: gameoftrees@openbsd.org
Date: Wed, 20 Mar 2024 01:45:29 +0100

On 2024/03/19 16:03:30 +0100, Stefan Sperling <stsp@stsp.name> wrote:
> This patch adds initial notification support to gotd.
> 
> I have been working on this on the side for a couple of months now.
> It turned into a bigger chunk of work than I initially expected.
> 
> By now, email notifications are working and have passing regression tests.
> I left out some configurable features that I had envisioned in my initial
> documentation draft for this feature because they added too much complexity.
> 
> The current behaviour produces 'got tag -l' style output for tags, and
> 'got log -d' style output for commits. If more than 50 commits are sent
> in one batch, we switch to 'got log -s' style.
> 
> I am happy enough with this behaviour for the initial version. We can
> of course keep tweaking this and add options if different behaviour turns
> out to be needed. In particular, sending full diffs would require some
> further changes in the diff code, because of int fd vs. FIlE *f.)
> 
> The HTTP bits are not finished, and I would appreciate help with them
> once this diff makes it into the tree. Once HTTP notifications are
> functional we can finally move the Got project's primary repository
> to gotd without losing commit notifications in our IRC channel.
> 
> OK?

The diff so big that it's better for this to go in as-is and work on it
on tree.  There are a few nits I noticed but it would just be a massive
wasting of time to ping-pong mails, so ok op@.



Thanks,

Omar Polo