From: Mark Jamsek Subject: Re: regress/tog: enable in sha256 mode To: Stefan Sperling Cc: Omar Polo , gameoftrees@openbsd.org Date: Wed, 7 Aug 2024 17:05:21 +1000 It might be best to increase COLUMNS in the `test_init $testname $COLUMNS $LINES` call at test entry. Although I do like op’s change if it can be fixed for SHA1 too. I can get to this in a few hours (~1000 Z) if op hasn’t already sorted it. (sorry for the top post) Sent from my iPhone > On 7 Aug 2024, at 4:51 PM, Stefan Sperling wrote: > > On Tue, Aug 06, 2024 at 11:33:40PM +0200, Omar Polo wrote: >> i'm not sure if it's better to do this or enlarge the size of the screen >> so we don't have to wrap. >> >> it is fully passing :) > > Unfortunately the tests are failing with GOT_TEST_ALGO=sha1 > >> +trim() >> +{ >> + expr "$2" : "\(.\{$1\}\)" >> +} > > Seems this returns an empty string if the input is shorter than > the requested trim amount. Maybe that causes sha1 tests to fail? >