From: Stefan Sperling <stsp@stsp.name>
Subject: Re: add tog log 't' keymap to diff arbitrary commits
To: Mark Jamsek <mark@jamsek.com>
Cc: gameoftrees@openbsd.org
Date: Fri, 9 Aug 2024 12:33:53 +0200

On Fri, Aug 09, 2024 at 08:10:14PM +1000, Mark Jamsek wrote:
> Stefan Sperling <stsp@stsp.name> wrote:
> > On Thu, Aug 08, 2024 at 08:41:39PM +1000, Mark Jamsek wrote:
> > > Updated diff actually changes the keymap from 't' to 'm'.
> > 
> > ok by me.
> > 
> > I see no reason to prevent this change from going in already.
> > It's self-contained, has little chance of breaking anything and
> > adds value.  I am happy with this.
> > 
> > Would be nice to have some tests, too, as always.
> 
> Here's basic regress for the new tog 'm' keymap covering (un)marking
> arbitrary commits, overwriting base commit marker, and rendering a diff
> view of marked and selected commits.
> 
> There's also a tiny change where I missed using the local convenience
> pointer reaching into struct tog_log_view_state

looks great, ok by me