From: Stefan Sperling <stsp@stsp.name>
Subject: Re: ignore lonely packs at a lower level
To: Omar Polo <op@omarpolo.com>
Cc: gameoftrees@openbsd.org
Date: Fri, 9 Aug 2024 18:05:48 +0200

On Fri, Aug 09, 2024 at 03:58:18PM +0200, Omar Polo wrote:
> instead of having to deal with these in gotwebd, deal with the lonely
> pack error at a lowel level, i.e. in got_repo_search_packidx and match
> routines.
> 
> This also makes the repo_purge_redundant_packfile skip over these lonely
> packs, but maybe the -p could be an implicit default behaviour of
> cleanup.  But not in this diff :)

The problem with making -p implicit is that we cannot tell why the
pack went missing. Maybe someone ran a bad script which moved the
pack file away for some reason? In this case the dangling index provides
a hint that a pack file should have existed in the repository at some point.

On the other hand, removing index files is not fatal because index files
can always be regenerated from the pack, so perhaps we should just remove
them, and update our documentation accordingly.

> thoughts?

Will check the diff later, out of time for now.