From: Mark Jamsek Subject: Re: tog: implement diff view 'p' keymap to write patch file To: Christian Weisgerber Cc: gameoftrees@openbsd.org Date: Fri, 16 Aug 2024 00:22:18 +1000 Christian Weisgerber wrote: > Mark Jamsek: > > > I agree. Perhaps naddy might prefer if it's written to the worktree if > > it's open--irrespective of whether it's the cwd--and /tmp in all other > > cases. > > No, inconsistency is worse. > > > In any case, I'll leave it up to naddy. If /tmp is a deal breaker and > > there's no viable alternative that you like, let's leave it out. > > It's your feature and your code, so very much not my decision! > I don't feel strongly about it either. Thanks, naddy :) > You have to wonder though if unveil() forcing unusual behavior isn't > a case of the tail wagging the dog. > > Anyway, I'll shut up now. Like Stefan, I always value your input and enjoy seeing your posts. I often come to think about things differently or learn something new. And whether we're in agreement or not, it makes me scrutinise my position more closely, which is always good. Considering naddy is not objecting to /tmp, is this diff 'p' keymap ok or would we rather drop this feature? -- Mark Jamsek GPG: F2FF 13DE 6A06 C471 CA80 E6E2 2930 DC66 86EE CF68