From: Stefan Sperling <stsp@stsp.name>
Subject: Re: unbreak gotwebd tag listing
To: Omar Polo <op@omarpolo.com>
Cc: gameoftrees@openbsd.org
Date: Sat, 7 Sep 2024 10:40:32 +0200

On Sat, Sep 07, 2024 at 10:34:08AM +0200, Omar Polo wrote:
> I broke this while fixing the links in the README.  The underlying
> problem is that got_get_repo_tags() cares whether qs->commit is set.  So
> the fix is to set it after calling got_get_repo_tags().
> 
> (imho it's unfortunate that we have so much code in got_operations.c that
> relies on the content of the querystring, but that's not an excuse for
> not having checked properly when doing the change in the first place.)
> 
> While here, I couldn't help but also do another change which is a no-op:
> don't duplicate the tag skipping logic and remove tags from the queue in
> got_operations instead.
> 
> ok?

I don't have time for an in-depth review right now.
But I tested the fix quickly and seems to work well, ok